Skip to content

regression: Empty topic being displayed in direct messages #35604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 1 commit into from
Mar 25, 2025
Merged

regression: Empty topic being displayed in direct messages #35604

kodiakhq merged 1 commit into from
Mar 25, 2025

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 24, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-1032

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 24, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 12d7167

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.5.0 milestone Mar 24, 2025
@dougfabris dougfabris changed the title regression: Empty topic being displayed regression: Empty topic being displayed in direct messages Mar 24, 2025
@codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (998147f) to head (12d7167).
Report is 1 commits behind head on release-7.5.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.5.0   #35604   +/-   ##
==============================================
  Coverage          59.72%   59.72%           
==============================================
  Files               2832     2832           
  Lines              68886    68886           
  Branches           15280    15280           
==============================================
  Hits               41144    41144           
  Misses             25066    25066           
  Partials            2676     2676
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35604/

Built to branch gh-pages at 2025-03-24 19:45 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dougfabris dougfabris marked this pull request as ready for review March 24, 2025 23:07
@dougfabris dougfabris requested a review from a team as a code owner March 24, 2025 23:07
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Mar 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 25, 2025
@kodiakhq kodiakhq bot merged commit 77fe429 into release-7.5.0 Mar 25, 2025
55 checks passed
@kodiakhq kodiakhq bot deleted the reg/empty-topic branch March 25, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavkrin abhinavkrin abhinavkrin approved these changes

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dougfabris @abhinavkrin @MartinSchoeler