fix: App update with no permission causes invalid_installation_disabled #35594
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: d0b511e The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35594 +/- ##
===========================================
+ Coverage 61.17% 61.20% +0.03%
===========================================
Files 3005 3007 +2
Lines 71381 71472 +91
Branches 16341 16343 +2
===========================================
+ Hits 43664 43742 +78
- Misses 24748 24760 +12
- Partials 2969 2970 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
d-gubert
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
…ed (#35594) Co-authored-by: Douglas Gubert <[email protected]>
Proposed changes (including videos or screenshots)
If an app is installed with permissions, but is updated with a version that requires no permissions (with no permissions in the manifest file), the app is marked as invalid_installation_disabled. This was happening because when we update the app's metadata in the database, we would do a simple update (no unset) which in term, would make that field different than the one in the manifest, which would case an error when comparing the checksums.
Issue(s)
Steps to test or reproduce
Expected: The app should be upload without any big issue
Actual: The app was being marked as invalid_installation_disabled and never got enabled
Further comments
CONN-564
This pull request addresses an issue in the Rocket.Chat repository where removing app permissions results in the app never being enabled, leading to an
invalid_installation_disablederror. The changes are documented in the changeset file.changeset/shy-moles-boil.md, although the documentation is noted to be clear, it lacks specific technical details. The fix is implemented in thefix/app-update-with-no-permission-errorbranch and is intended to be merged into thedevelopbranch.