-
Notifications
You must be signed in to change notification settings - Fork 13k
refactor: remove deprecated KonchatNotification
#35589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35589 +/- ##
===========================================
- Coverage 59.73% 59.72% -0.01%
===========================================
Files 2830 2829 -1
Lines 68270 68263 -7
Branches 15134 15133 -1
===========================================
- Hits 40778 40771 -7
Misses 24881 24881
Partials 2611 2611
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
abea03d to
7277277
Compare
aba14cf to
0cea133
Compare
ARCH-1517
notifyfrom meteor #35585 is mergedProposed changes (including videos or screenshots)
notificationManageremitter class to store notification permission statususeNotificationPermissionto handle notification permission request and changesuseNotificationAllowedto sync with external store the notification status and return the updated valueallowedto finally
KonchatNotificationIssue(s)
Steps to test or reproduce
Further comments