Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Mar 21, 2025

Proposed changes (including videos or screenshots)

This PR adds error state to the Unit field within the EditDepartment page.

Screenshot 2025-03-21 at 12 09 45

Issue(s)

CTZ-23

Steps to test or reproduce

  • Access Enterprise workspace
  • Go Omnichannel > Department
  • New department
  • Field "Unit" should be visible
  • Select a unit
  • Select none as a unit
  • Should display error message "Unit required"

Further comments

Introduced here: #35370

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 80c09b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35583/

Built to branch gh-pages at 2025-03-21 17:21 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (fbcf5da) to head (80c09b1).
Report is 1 commits behind head on release-7.5.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.5.0   #35583   +/-   ##
==============================================
  Coverage          59.72%   59.72%           
==============================================
  Files               2832     2832           
  Lines              68886    68886           
  Branches           15280    15280           
==============================================
  Hits               41144    41144           
  Misses             25066    25066           
  Partials            2676     2676           
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva changed the base branch from regression/department-unit-field-disabled to release-7.5.0 March 21, 2025 17:14
@aleksandernsilva aleksandernsilva dismissed lucas-a-pelegrino’s stale review March 21, 2025 17:14

The base branch was changed.

@aleksandernsilva aleksandernsilva force-pushed the regression/department-unit-error-state branch from c302403 to f4b6ce8 Compare March 21, 2025 17:16
@aleksandernsilva aleksandernsilva force-pushed the regression/department-unit-error-state branch from f4b6ce8 to 80c09b1 Compare March 21, 2025 17:40
@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 21, 2025 18:39
@aleksandernsilva aleksandernsilva requested review from a team as code owners March 21, 2025 18:39
@aleksandernsilva aleksandernsilva added this to the 7.5.0 milestone Mar 21, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Mar 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 21, 2025
@kodiakhq kodiakhq bot merged commit 5a20492 into release-7.5.0 Mar 21, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the regression/department-unit-error-state branch March 21, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants