Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 21, 2025

Proposed changes (including videos or screenshots)

  • It moves the UserPresenceContext to ui-context package in order to allow its usage in other packages, such as mock-providers
  • Removes deprecated usePresence and renames useUserData to useUserPresence that consumes the proper UserPresenceContext.Provider
  • Creates withUsers allowing the UserPresence mocking

Issue(s)

Steps to test or reproduce

N/A

Further comments

CORE-1036

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 58345bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.6.0 milestone Mar 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35582/

Built to branch gh-pages at 2025-03-21 19:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (bffc49f) to head (58345bc).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35582      +/-   ##
===========================================
- Coverage    59.73%   59.72%   -0.01%     
===========================================
  Files         2830     2830              
  Lines        68379    68363      -16     
  Branches     15161    15161              
===========================================
- Hits         40844    40829      -15     
+ Misses       24919    24918       -1     
  Partials      2616     2616              
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the refactor/userPresence-context branch from 93355de to 2ba8c92 Compare March 21, 2025 15:17
@dougfabris dougfabris marked this pull request as ready for review March 21, 2025 16:52
@dougfabris dougfabris requested review from a team as code owners March 21, 2025 16:52
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Mar 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 21, 2025
@ggazzo ggazzo merged commit 5cc6b21 into develop Mar 21, 2025
52 checks passed
@ggazzo ggazzo deleted the refactor/userPresence-context branch March 21, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants