Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Mar 21, 2025

Proposed changes (including videos or screenshots)

This PR fixes a bug where the unit field in the EditDepartment page becomes disabled immediately after selecting a unit. The field should only become disabled after a unit has been set and saved.

Now, the field remains editable until the department is saved, ensuring users can freely change the business unit while creating a department.

Issue(s)

CTZ-22

Steps to test or reproduce

  • Access Enterprise workspace
  • Go Omnichannel > Department
  • New department
  • Field "Unit" should be visible
  • Select a unit
  • Field should remain enabled
  • Save and edit
  • Unit field should be disabled

Further comments

Introduced here: #35370

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 9ce23a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35581/

Built to branch gh-pages at 2025-03-21 14:44 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (cc4111c) to head (9ce23a8).
Report is 1 commits behind head on release-7.5.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.5.0   #35581   +/-   ##
==============================================
  Coverage          59.72%   59.72%           
==============================================
  Files               2832     2832           
  Lines              68886    68886           
  Branches           15280    15280           
==============================================
  Hits               41144    41144           
  Misses             25066    25066           
  Partials            2676     2676           
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 21, 2025 17:01
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner March 21, 2025 17:01
@aleksandernsilva aleksandernsilva added this to the 7.5.0 milestone Mar 21, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Mar 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 21, 2025
@kodiakhq kodiakhq bot merged commit fbcf5da into release-7.5.0 Mar 21, 2025
52 of 60 checks passed
@kodiakhq kodiakhq bot deleted the regression/department-unit-field-disabled branch March 21, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants