Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Mar 20, 2025

Proposed changes (including videos or screenshots)

Inside /apps/meteor/ run:
yarn translation-replace-sprintf-params "<TRANSLATION_KEY">

The script will identify all %s tokens and prompt for names to replace it. Example:

yarn translation-replace-sprintf-params "Leave_Private_Warning"
Found 67 translation files
Found translation key "Leave_Private_Warning" with value: "Are you sure you want to leave the discussion with "%s"?"
This string contains 1 "%s" tokens
Please provide 1 parameter names (comma-separated): roomName
Updated /Users/gabriellsh/dev/Rocket.Chat/packages/i18n/src/locales/af.i18n.json
Updated /Users/gabriellsh/dev/Rocket.Chat/packages/i18n/src/locales/ar.i18n.json
[...]
All translation files have been updated

Issue(s)

CORE-1044

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 20, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: c962af0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh added this to the 7.6.0 milestone Mar 20, 2025
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Mar 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35569/

Built to branch gh-pages at 2025-03-20 21:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (11d642c) to head (c962af0).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35569   +/-   ##
========================================
  Coverage    59.66%   59.66%           
========================================
  Files         2826     2826           
  Lines        68287    68287           
  Branches     15128    15128           
========================================
  Hits         40744    40744           
  Misses       24932    24932           
  Partials      2611     2611           
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriellsh gabriellsh requested a review from a team as a code owner March 20, 2025 21:28
@gabriellsh gabriellsh force-pushed the chore/sprintfReplaceScript branch from 06f1cc0 to c962af0 Compare March 20, 2025 21:31
@ggazzo ggazzo merged commit 05a23b4 into develop Mar 20, 2025
61 of 64 checks passed
@ggazzo ggazzo deleted the chore/sprintfReplaceScript branch March 20, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants