Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Mar 20, 2025

ARCH-1504

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 20, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: d260af6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35567/

Built to branch gh-pages at 2025-03-20 18:11 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (8606cf6) to head (d260af6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35567      +/-   ##
===========================================
- Coverage    59.66%   59.66%   -0.01%     
===========================================
  Files         2826     2826              
  Lines        68285    68282       -3     
  Branches     15128    15128              
===========================================
- Hits         40744    40741       -3     
  Misses       24930    24930              
  Partials      2611     2611              
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the refactor/notify-new-room branch from 6170fcb to d260af6 Compare March 20, 2025 17:39
@juliajforesti juliajforesti marked this pull request as ready for review March 20, 2025 17:49
@juliajforesti juliajforesti requested a review from a team as a code owner March 20, 2025 17:49
@ggazzo ggazzo added this to the 7.6.0 milestone Mar 20, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Mar 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2025
@kodiakhq kodiakhq bot merged commit af03a61 into develop Mar 20, 2025
52 checks passed
@kodiakhq kodiakhq bot deleted the refactor/notify-new-room branch March 20, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants