-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Suspend SettingsProvider
#35561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35561 +/- ##
===========================================
- Coverage 59.67% 59.66% -0.01%
===========================================
Files 2826 2826
Lines 68313 68293 -20
Branches 15134 15131 -3
===========================================
- Hits 40764 40748 -16
+ Misses 24937 24933 -4
Partials 2612 2612
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a87cecc to
9ca894f
Compare
https://rocketchat.atlassian.net/browse/ARCH-1505
Proposed changes (including videos or screenshots)
It suspends the rendering of
SettingsProvideruntil the settings are loaded.Issue(s)
Steps to test or reproduce
Further comments
Might be interesting in the future to make the
SettingsContextconsumers themselves suspend components.