Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 19, 2025

https://rocketchat.atlassian.net/browse/ARCH-1506

Proposed changes (including videos or screenshots)

It does a small change in the CachedCollection API to split behaviors that depend on the authenticated user.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 19, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2025

⚠️ No Changeset found

Latest commit: a23e27e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan force-pushed the chore/cache-collection-classes branch from 26561c5 to 33e5c8d Compare March 19, 2025 17:24
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35556/

Built to branch gh-pages at 2025-03-20 04:16 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.67%. Comparing base (3b54061) to head (fd6bb97).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35556      +/-   ##
===========================================
- Coverage    59.67%   59.67%   -0.01%     
===========================================
  Files         2826     2826              
  Lines        68313    68311       -2     
  Branches     15134    15134              
===========================================
- Hits         40764    40762       -2     
  Misses       24937    24937              
  Partials      2612     2612              
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan marked this pull request as ready for review March 19, 2025 18:36
@tassoevan tassoevan requested a review from a team as a code owner March 19, 2025 18:36
@tassoevan tassoevan force-pushed the chore/cache-collection-classes branch from a23e27e to fd6bb97 Compare March 20, 2025 04:09
@tassoevan tassoevan changed the title chore: Subclasses of CacheCollection chore: Subclasses of CachedCollection Mar 20, 2025
@ggazzo ggazzo merged commit 21048fb into develop Mar 20, 2025
49 checks passed
@ggazzo ggazzo deleted the chore/cache-collection-classes branch March 20, 2025 17:08
@ggazzo ggazzo added this to the 7.6.0 milestone Mar 20, 2025
abhinavkrin pushed a commit that referenced this pull request Mar 24, 2025
abhinavkrin pushed a commit that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants