-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Subclasses of CachedCollection
#35556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
26561c5 to
33e5c8d
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35556 +/- ##
===========================================
- Coverage 59.67% 59.67% -0.01%
===========================================
Files 2826 2826
Lines 68313 68311 -2
Branches 15134 15134
===========================================
- Hits 40764 40762 -2
Misses 24937 24937
Partials 2612 2612
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a23e27e to
fd6bb97
Compare
CacheCollectionCachedCollection
https://rocketchat.atlassian.net/browse/ARCH-1506
Proposed changes (including videos or screenshots)
It does a small change in the
CachedCollectionAPI to split behaviors that depend on the authenticated user.Issue(s)
Steps to test or reproduce
Further comments