-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Calling registerGuest multiple times causes loss of communication #35555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4ac69ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
5f0933b to
6983860
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35555 +/- ##
========================================
Coverage 59.67% 59.67%
========================================
Files 2826 2826
Lines 68357 68357
Branches 15142 15142
========================================
Hits 40793 40793
Misses 24951 24951
Partials 2613 2613
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
b73df3a to
4ac69ad
Compare
Proposed changes (including videos or screenshots)
This PR resolves an issue where Livechat would lose connection when
registerGuestwas called multiple times with the same token via the Livechat API.The problem occurred because
Livechat.unsubscribeAllwas being called on everyregisterGuestcall, regardless of whether the guest token had actually changed.Issue(s)
CTZ-7
Steps to test or reproduce
Further comments