Skip to content

regression: topic rendering in DMs in new navigation #35553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Mar 24, 2025
Merged

regression: topic rendering in DMs in new navigation #35553

kodiakhq merged 2 commits into from
Mar 24, 2025

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Mar 19, 2025 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

Introduced here: #35417

This PR fixes an issue which causes topic to render in DMs in new navigation.

Issue(s)

Steps to test or reproduce

Further comments

CORE-1035

@abhinavkrin abhinavkrin requested a review from a team as a code owner March 19, 2025 14:58
@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4ca381e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 19, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35553/

Built to branch gh-pages at 2025-03-24 13:31 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (a6d95d7) to head (4ca381e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35553   +/-   ##
========================================
  Coverage    59.72%   59.72%           
========================================
  Files         2830     2830           
  Lines        68363    68363           
  Branches     15161    15161           
========================================
  Hits         40829    40829           
  Misses       24918    24918           
  Partials      2616     2616
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gabriellsh
gabriellsh requested changes Mar 19, 2025
View reviewed changes
dougfabris
dougfabris requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the fix. Please check the verification inside RoomTopic
Also we need a task for it!

@dougfabris dougfabris added this to the 7.5.0 milestone Mar 19, 2025
@abhinavkrin abhinavkrin force-pushed the regression/topic-rendering-in-dms-in-new-navigation branch from f5dec38 to 79c8a4d Compare March 20, 2025 10:08
@abhinavkrin abhinavkrin force-pushed the regression/topic-rendering-in-dms-in-new-navigation branch from 79c8a4d to 9eca089 Compare March 20, 2025 17:33
@abhinavkrin abhinavkrin requested review from a team as code owners March 20, 2025 17:33
@abhinavkrin abhinavkrin changed the base branch from develop to release-7.5.0 March 20, 2025 17:33
@dougfabris dougfabris removed request for a team March 20, 2025 17:51
@dougfabris dougfabris changed the base branch from release-7.5.0 to develop March 21, 2025 21:05
@dougfabris dougfabris force-pushed the regression/topic-rendering-in-dms-in-new-navigation branch from 9eca089 to 6f1415d Compare March 21, 2025 21:08
@abhinavkrin abhinavkrin force-pushed the regression/topic-rendering-in-dms-in-new-navigation branch from 7aa1291 to d460cad Compare March 24, 2025 11:51
@abhinavkrin abhinavkrin requested a review from a team as a code owner March 24, 2025 11:51
@abhinavkrin abhinavkrin changed the base branch from develop to release-7.5.0 March 24, 2025 11:51
@abhinavkrin abhinavkrin force-pushed the regression/topic-rendering-in-dms-in-new-navigation branch 2 times, most recently from 335df74 to eb3dacc Compare March 24, 2025 12:06
@dougfabris dougfabris changed the base branch from release-7.5.0 to develop March 24, 2025 13:23
abhinavkrin and others added 2 commits March 24, 2025 10:27
@abhinavkrin @dougfabris
regression: topic rendering in discussion in new navigation
e09b36d 
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@dougfabris
fix: review
4ca381e
@dougfabris dougfabris force-pushed the regression/topic-rendering-in-dms-in-new-navigation branch from 562090e to 4ca381e Compare March 24, 2025 13:27
@dougfabris dougfabris removed the request for review from a team March 24, 2025 13:28
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Mar 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 24, 2025
@kodiakhq kodiakhq bot merged commit b1a739c into develop Mar 24, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the regression/topic-rendering-in-dms-in-new-navigation branch March 24, 2025 15:16
ggazzo added a commit that referenced this pull request Mar 24, 2025
@ggazzo
regression: topic rendering in DMs in new navigation (#35553)
8ccdff8
ggazzo added a commit that referenced this pull request Mar 24, 2025
@ggazzo @dougfabris
regression: topic rendering in DMs in new navigation (#35553)
998147f 
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougfabris dougfabris dougfabris approved these changes

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinavkrin @dougfabris @gabriellsh