-
Notifications
You must be signed in to change notification settings - Fork 13k
feat(apps-engine): adds executeLivechatRoomCreatePrevent event #35486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apps-engine): adds executeLivechatRoomCreatePrevent event #35486
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4302d5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…eate-prevent-livechat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35486 +/- ##
========================================
Coverage 59.66% 59.66%
========================================
Files 2826 2826
Lines 68378 68378
Branches 15149 15149
========================================
Hits 40800 40800
Misses 24964 24964
Partials 2614 2614
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
An App needs to be able to prevent the creation of a room. This is only possible for DMs and channels, not Livechat rooms.
This PR adds a hook called executePreLivechatRoomCreatePrevent to prevent the creation of a Livechat room.
Issue(s)
Steps to test or reproduce
Further comments
Currently, the end-to-end tests rely on a test application (here). We modified this application to run the end-to-end tests (here). So, before merging this PR, we must ensure that the master branch of this app incorporates the changes. Then, we need to update the reference file in this PR (insert-apps.ts) to point to the app file on the master branch.
CTZ-3