Skip to content

Conversation

@alfredodelfabro
Copy link
Member

@alfredodelfabro alfredodelfabro commented Mar 13, 2025

Proposed changes (including videos or screenshots)

An App needs to be able to prevent the creation of a room. This is only possible for DMs and channels, not Livechat rooms.

This PR adds a hook called executePreLivechatRoomCreatePrevent to prevent the creation of a Livechat room.

Issue(s)

Steps to test or reproduce

Further comments

Currently, the end-to-end tests rely on a test application (here). We modified this application to run the end-to-end tests (here). So, before merging this PR, we must ensure that the master branch of this app incorporates the changes. Then, we need to update the reference file in this PR (insert-apps.ts) to point to the app file on the master branch.

CTZ-3

@alfredodelfabro alfredodelfabro requested review from a team as code owners March 13, 2025 12:55
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 13, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: 4302d5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/apps-engine Minor
@rocket.chat/apps Minor
@rocket.chat/meteor Minor
@rocket.chat/core-services Patch
@rocket.chat/core-typings Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/rest-typings Minor
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alfredodelfabro alfredodelfabro added this to the 7.5.0 milestone Mar 13, 2025
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (280fcce) to head (312b03b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35486   +/-   ##
========================================
  Coverage    59.66%   59.66%           
========================================
  Files         2826     2826           
  Lines        68378    68378           
  Branches     15149    15149           
========================================
  Hits         40800    40800           
  Misses       24964    24964           
  Partials      2614     2614           
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sampaiodiego
sampaiodiego previously approved these changes Mar 19, 2025
d-gubert
d-gubert previously approved these changes Mar 19, 2025
sampaiodiego
sampaiodiego previously approved these changes Mar 19, 2025
@sampaiodiego sampaiodiego dismissed stale reviews from d-gubert and themself via 3ebbddb March 19, 2025 18:30
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Mar 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2025
@sampaiodiego sampaiodiego merged commit 0d96d63 into RocketChat:develop Mar 20, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants