-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Omnichannel continuous sound notification not being played #35480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b04b934 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35480 +/- ##
========================================
Coverage 59.67% 59.67%
========================================
Files 2826 2826
Lines 68357 68357
Branches 15142 15142
========================================
Hits 40793 40793
Misses 24951 24951
Partials 2613 2613
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
71753c8 to
3f1ec33
Compare
Proposed changes (including videos or screenshots)
This PR fixes Omnichannel's continuous notification not playing due to an invalid volume value being passed to the HTMLMediaElement.
Issue(s)
Steps to test or reproduce
Further comments
Introduced here: #33902
CTZ-6