Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Mar 12, 2025

Proposed changes (including videos or screenshots)

This PR fixes Omnichannel's continuous notification not playing due to an invalid volume value being passed to the HTMLMediaElement.

Screenshot 2025-03-12 at 11 57 48

Issue(s)

Steps to test or reproduce

  • Workspace > Settings > Omnichannel
  • Enable "Continuous sound notifications for new omnichannel room"
  • Start a livechat conversation
  • Room sound notification should play continuously

Further comments

Introduced here: #33902
CTZ-6

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 12, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: b04b934

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva changed the title fix: Omnichannel continuous notification not playing fix: Omnichannel continuous sound notification not being played Mar 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35480/

Built to branch gh-pages at 2025-03-19 18:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.67%. Comparing base (20fef4d) to head (3f1ec33).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35480   +/-   ##
========================================
  Coverage    59.67%   59.67%           
========================================
  Files         2826     2826           
  Lines        68357    68357           
  Branches     15142    15142           
========================================
  Hits         40793    40793           
  Misses       24951    24951           
  Partials      2613     2613           
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 12, 2025 17:10
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner March 12, 2025 17:10
@aleksandernsilva aleksandernsilva marked this pull request as draft March 12, 2025 17:32
@aleksandernsilva aleksandernsilva force-pushed the fix/oc-volume-continuous-notification branch from 71753c8 to 3f1ec33 Compare March 19, 2025 18:08
@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 19, 2025 18:54
@aleksandernsilva aleksandernsilva added this to the 7.5.0 milestone Mar 19, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025
@aleksandernsilva aleksandernsilva added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2025
@sampaiodiego sampaiodiego merged commit 1001da6 into develop Mar 20, 2025
6 of 8 checks passed
@sampaiodiego sampaiodiego deleted the fix/oc-volume-continuous-notification branch March 20, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants