chore(deps-dev): bump storybook from 8.5.3 to 8.6.4#35478
Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
storybook from 8.5.3 to 8.6.4
dougfabris
approved these changes
Mar 12, 2025
julio-rocketchat
approved these changes
Mar 13, 2025
Member
|
@MarcosSpessatto can probably help us with the architecture review here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR upgrades storybook from 8.5.3 to 8.6.4 (changelog) as well as eslint-plugin-storybook from 0.11.0 to 0.11.4 (changelog).
In 8.5.8, storybook upgraded esbuild to 0.25.0. It addressed a moderate vulnerability, although it is very unlikely to affect this repo.
As a bonus, this aligns with the apps-engine current usage of
esbuild ^0.25.0, reducing the overall number of dependencies in the monorepo by not transitively pulling inesbuild 0.24.0from storybook:38 packages were added to the project, and 40 were removed (+ 1.05 MiB).The other dependency removed was also transitive:
vitest-axe(storybookjs/storybook#30442)Also an important feature for accessibility testing is made available by this upgrade:
Issue(s)
Steps to test or reproduce
Further comments
From Storybook 8.6.0 changelog: