Skip to content

chore(deps-dev): bump storybook from 8.5.3 to 8.6.4#35478

Merged
ggazzo merged 7 commits into
RocketChat:developfrom
cardoso:storybook-6.4
Mar 14, 2025
Merged

chore(deps-dev): bump storybook from 8.5.3 to 8.6.4#35478
ggazzo merged 7 commits into
RocketChat:developfrom
cardoso:storybook-6.4

Conversation

@cardoso

@cardoso cardoso commented Mar 12, 2025

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

This PR upgrades storybook from 8.5.3 to 8.6.4 (changelog) as well as eslint-plugin-storybook from 0.11.0 to 0.11.4 (changelog).

In 8.5.8, storybook upgraded esbuild to 0.25.0. It addressed a moderate vulnerability, although it is very unlikely to affect this repo.

As a bonus, this aligns with the apps-engine current usage of esbuild ^0.25.0, reducing the overall number of dependencies in the monorepo by not transitively pulling in esbuild 0.24.0 from storybook:

38 packages were added to the project, and 40 were removed (+ 1.05 MiB).

The other dependency removed was also transitive: vitest-axe (storybookjs/storybook#30442)

Also an important feature for accessibility testing is made available by this upgrade:

Issue(s)

Steps to test or reproduce

yarn
yarn build
yarn storybook

Further comments

From Storybook 8.6.0 changelog:

The 8.6 release focuses on Storybook Test, which brings realtime component, accessibility, and visual UI tests to your favorite component workshop.

Here’s what’s new:

🎁 Storybook Test installer for out-of-the-box tests in new projects
🦾 Accessibility “todo” workflow to systematically fix a11y violations
🗜️ 80% smaller create-storybook package for much faster installs
🧪 Dozens of Test fixes based on user feedback
📕 Docs fixes for table of contents, code snippets, and more
🚨 Key security fixes for Vite and ESbuild
💯 Hundreds more improvements
...

@cardoso cardoso requested review from a team as code owners March 12, 2025 13:06
@dionisio-bot

dionisio-bot Bot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.5.0, but it targets 7.4.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Mar 12, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a897a24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cardoso cardoso changed the title chore(dev-deps): update storybook to 8.6.4 chore(deps-dev): bump storybook to 8.6.4 Mar 12, 2025
@cardoso cardoso changed the title chore(deps-dev): bump storybook to 8.6.4 chore(deps-dev): bump storybook from 8.5.3 to 8.6.4 Mar 12, 2025
@julio-rocketchat

Copy link
Copy Markdown
Member

@MarcosSpessatto can probably help us with the architecture review here

@ggazzo ggazzo added this to the 7.5.0 milestone Mar 14, 2025
@ggazzo ggazzo merged commit f9bdafc into RocketChat:develop Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants