fix: Composer Popup doesn't scroll results #35468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ddf8f0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
dougfabris
changed the title
dougfabris
requested changes
May 14, 2025
Contributor
Author
|
I was thinking of that well will do that and raise my PR again |
dougfabris
requested changes
May 16, 2025
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
approved these changes
May 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose there are a lot of people in the channel, when you try to mention someone you use '@' that opens a popup which has a list of people the list sometimes might be big that you need to scroll down. In the current version I can only go down int the using arrow down key but can't scroll.
Proposed changes (including videos or screenshots)
Here, now the scrolling feature works well.
Issue(s)
Closes #35447
CORE-1155
Steps to test or reproduce
Use @ in a very big and active room to mention someone try to scroll down.