-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Default preference value for receiveLoginDetectionEmail
#35467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 261c029 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35467 +/- ##
========================================
Coverage 59.64% 59.64%
========================================
Files 2827 2827
Lines 68511 68511
Branches 15183 15183
========================================
Hits 40862 40862
Misses 25001 25001
Partials 2648 2648
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Currently, on the server side, the default value for this preference is
truewhile on client side the default value is being shown as false.This creates a confusion between the actual and expected behavior.
To keep with this current behavior, this PR updates the default value on client side to be true.
Issue(s)
CORE-1058
Steps to test or reproduce
Further comments