-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Livechat department incorrect param name #35455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35455 +/- ##
========================================
Coverage 59.62% 59.62%
========================================
Files 2832 2832
Lines 68356 68356
Branches 15141 15147 +6
========================================
Hits 40754 40754
Misses 24995 24995
Partials 2607 2607
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
68638cb to
74af475
Compare
…osingChat as true
KevLehman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice :)
sampaiodiego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually a bug fix right?
|
@sampaiodiego I don't think this is considered a bugfix because there was nothing breaking before this change. |
|
oh thx @aleksandernsilva , I didn't check all |
Proposed changes (including videos or screenshots)
This PR corrects a typo in the
POSTLivechatDepartmentSchema, renaming the keyrequestTagsBeforeClosingChattorequestTagBeforeClosingChatwhich is the correct param name.This does not classify as a breaking change since this change only affects ajv schema and it accepts adittional params. The code always referenced the correct param name.
Issue(s)
SUP-614
Steps to test or reproduce
N/A
Further comments
This PR was split from the discussion here