Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Mar 10, 2025

Proposed changes (including videos or screenshots)

This PR corrects a typo in the POSTLivechatDepartmentSchema, renaming the key requestTagsBeforeClosingChat to requestTagBeforeClosingChat which is the correct param name.

This does not classify as a breaking change since this change only affects ajv schema and it accepts adittional params. The code always referenced the correct param name.

Issue(s)

SUP-614

Steps to test or reproduce

N/A

Further comments

This PR was split from the discussion here

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 94da08c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35455/

Built to branch gh-pages at 2025-04-14 15:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (2ee1a81) to head (94da08c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35455   +/-   ##
========================================
  Coverage    59.62%   59.62%           
========================================
  Files         2832     2832           
  Lines        68356    68356           
  Branches     15141    15147    +6     
========================================
  Hits         40754    40754           
  Misses       24995    24995           
  Partials      2607     2607           
Flag Coverage Δ
unit 75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva force-pushed the chore/department-incorrect-param branch from 68638cb to 74af475 Compare April 8, 2025 19:23
Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice :)

@aleksandernsilva aleksandernsilva marked this pull request as ready for review April 9, 2025 18:56
@aleksandernsilva aleksandernsilva requested review from a team as code owners April 9, 2025 18:56
@aleksandernsilva aleksandernsilva added this to the 7.6.0 milestone Apr 9, 2025
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Apr 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 14, 2025
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually a bug fix right?

@aleksandernsilva
Copy link
Contributor Author

aleksandernsilva commented Apr 14, 2025

@sampaiodiego I don't think this is considered a bugfix because there was nothing breaking before this change.
The ajv schema accepted additional properties and the code was already using the correct param, so everything worked as expected even with the incorrect param name. This change is about correcting the param name, but won't affect functionality.

@sampaiodiego
Copy link
Member

oh thx @aleksandernsilva , I didn't check all ajv schema so I missed the additionalProperties: true.. thx ❤️

@kodiakhq kodiakhq bot merged commit ba78cbe into develop Apr 14, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the chore/department-incorrect-param branch April 14, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants