fix: Filtering non ascii bad words #35418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c94103e The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35418 +/- ##
========================================
Coverage 59.66% 59.66%
========================================
Files 2826 2826
Lines 68369 68379 +10
Branches 15148 15149 +1
========================================
+ Hits 40793 40801 +8
- Misses 24962 24964 +2
Partials 2614 2614
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
@kody start-review |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
apps/meteor/server/services/messages/hooks/BeforeSaveBadWords.ts
Outdated
Show resolved
Hide resolved
ricardogarim
requested changes
Mar 7, 2025
apps/meteor/server/services/messages/hooks/BeforeSaveBadWords.ts
Outdated
Show resolved
Hide resolved
Contributor
|
ricardogarim
previously approved these changes
Mar 7, 2025
debdutdeb
reviewed
Mar 8, 2025
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ricardogarim
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SUP-704
This pull request aims to enhance the content moderation capabilities of the Rocket.Chat application by improving the bad words filtering system. It introduces support for filtering non-ASCII bad words, allowing for better moderation of messages in languages other than English. The changes include the addition of regex-based pattern matching to the existing bad words filter, which improves word boundary detection and ensures more consistent censorship of inappropriate language. These updates are implemented in the
BeforeSaveBadWords.tsfile and documented in the.changeset/witty-ads-visit.mdfile. The source branch for these changes isfix/non-ascii-bad-words, and the target branch isdevelop.