-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: don't allow omnichannel agents to join closed rooms #35414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 57015a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35414 +/- ##
===========================================
+ Coverage 59.64% 59.67% +0.03%
===========================================
Files 2827 2828 +1
Lines 68475 68729 +254
Branches 15177 15224 +47
===========================================
+ Hits 40839 41016 +177
- Misses 24989 25055 +66
- Partials 2647 2658 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
|
Proposed changes (including videos or screenshots)
Fixes issue of agents trying to preview a closed livechat room without
preview-c-roompermission dIssue(s)
SUP-748
Steps to test or reproduce
the
join channelscreen should not appear for livechat rooms, as these cannot be joined once closed and they have their own permissions for visibilityFurther comments