Skip to content

Conversation

@AyushKumar123456789
Copy link
Contributor

@AyushKumar123456789 AyushKumar123456789 commented Mar 2, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Closes #35385

Steps to test or reproduce

  1. Open the sidebar using the three horizontal lines.
  2. Click on the RoomMenuaction icon to open the panel.
  3. With the RoomMenuaction panel open, collapse the sidebar.
  4. Observe that the RoomMenuaction panel remains visible.

Before :

SideBarRoomMenu.mp4

After :

Sidebar.roommenu.correct.mp4

Further comments

@AyushKumar123456789 AyushKumar123456789 requested a review from a team as a code owner March 2, 2025 19:43
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 2, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2025

🦋 Changeset detected

Latest commit: d649a19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AyushKumar123456789 AyushKumar123456789 changed the title FIX : Sidebar RoomMenuaction remains visible after sidebar collapse fix : Sidebar RoomMenuaction anomaly in lower size Mar 2, 2025
@AyushKumar123456789 AyushKumar123456789 changed the title fix : Sidebar RoomMenuaction anomaly in lower size fix: Sidebar RoomMenuaction anomaly in lower size Mar 2, 2025
@codecov
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.42%. Comparing base (19f34c5) to head (c57508d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35386   +/-   ##
========================================
  Coverage    59.42%   59.42%           
========================================
  Files         2829     2829           
  Lines        68334    68334           
  Branches     15133    15133           
========================================
  Hits         40610    40610           
  Misses       25066    25066           
  Partials      2658     2658           
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 7.5.0 milestone Mar 6, 2025
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Mar 6, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 6, 2025
@kodiakhq kodiakhq bot merged commit 7480c90 into RocketChat:develop Mar 6, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI/UX bug: Sidebar RoomMenuaction Remains Visible After Sidebar Collapse.

3 participants