-
Notifications
You must be signed in to change notification settings - Fork 13k
refactor: grandfather apps installed before 7.0.0 while handling license downgrades #35374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 8bc95d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35374 +/- ##
========================================
Coverage 59.67% 59.67%
========================================
Files 2826 2826
Lines 68313 68313
Branches 15134 15134
========================================
Hits 40764 40764
Misses 24937 24937
Partials 2612 2612
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5f986ed to
d84a316
Compare
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more a fix rather than a refactor.
|
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
db1ba72 to
2bc5bbb
Compare
Proposed changes (including videos or screenshots)
Previously, when a workspace downgraded from a trial or paid license to the community edition, all installed apps (both marketplace and private apps) remained enabled, regardless of the workspace’s new limitations. This led to workspaces retaining premium features beyond what was intended.
Marketplace Apps:
Private Apps:
Issue(s)
Steps to test or reproduce
Marketplace Apps
Private Apps
Grandfathered Private Apps
rocketchat_statisticscollection.versionfield to a pre-7 version (e.g., 6.9.0).installedDateto a date before the upgrade to version 7.rocketchat_appscollection):createdDatefield to a date that aligns with the pre-7 installation date.Further comments
It's a bit tricky to enforce the grandfathering condition reliably. After discussing with the team, we identified a potential approach: checking app statistics. If any recorded statistics indicate usage from a pre-7 version, we can infer that the workspace previously ran that version, allowing us to determine eligibility for grandfathering.