fix: 'room-changed' event race condition #35371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ab6bf4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35371 +/- ##
===========================================
- Coverage 59.64% 59.64% -0.01%
===========================================
Files 2828 2828
Lines 68539 68533 -6
Branches 15193 15192 -1
===========================================
- Hits 40883 40879 -4
+ Misses 25008 25006 -2
Partials 2648 2648
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lucas-a-pelegrino
previously approved these changes
Mar 3, 2025
dougfabris
requested changes
Mar 5, 2025
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
gabriellsh
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The
room-changedevent was misfiring due to theRoomManager.openfunction being called before the listener was attached.First time entering a room would work correctly, but after cache is available in the
useOpenRoomhook,RoomProvideris able to render using said cache, before the queryFn would rerun with the new room data.This caused the event to not fire after returnning the first time to a room, and subsequent events would dispatch the previous room's data.
Issue(s)
SUP-746
Steps to test or reproduce
messageevent listener to the window (parent.addEventListener('message', ...))Further comments