fix: inner attachment empty when quoting multiple times #35369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 57af783 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
abhinavkrin
force-pushed
the
fix/quoting-attachment-inner-empty
branch
from
017207b to
13776e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35369 +/- ##
===========================================
- Coverage 59.67% 59.64% -0.04%
===========================================
Files 2829 2828 -1
Lines 68786 68542 -244
Branches 15236 15193 -43
===========================================
- Hits 41051 40884 -167
+ Misses 25076 25010 -66
+ Partials 2659 2648 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
MarcosSpessatto
suggested changes
Mar 6, 2025
apps/meteor/tests/unit/server/services/messages/hooks/BeforeSaveJumpToMessage.tests.ts
Show resolved
Hide resolved
MarcosSpessatto
approved these changes
Mar 7, 2025
abhinavkrin
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes an issue where quoting an attachment (image, video, file, audio) multiple times resulted in the inner attachment being empty. The description and preview was lost in the inner message.
before
after
Issue(s)
Steps to test or reproduce
Further comments
CORE-37