Skip to content

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Feb 27, 2025

Proposed changes (including videos or screenshots)

The issue was traced to the use of Unicode property escapes (\p{S} and \p{P}) in the Haskell grammar definition of highlight.js, as detailed in highlight.js#4013.
The issue only occurred in production, likely due to differences in how the build process handles regex.

So, I have rolled back to version 11.8.0 as hotfix, which resolves the issue.

Issue(s)

Steps to test or reproduce

Further comments

CORE-1005

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 27, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 499eddb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@abhinavkrin abhinavkrin added this to the 7.4.0 milestone Feb 27, 2025
@abhinavkrin abhinavkrin force-pushed the regression/regex-error-multi-line-code branch from 4ab0aa4 to 499eddb Compare February 27, 2025 09:21
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (2c79559) to head (499eddb).
Report is 2 commits behind head on release-7.4.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.4.0   #35347   +/-   ##
==============================================
  Coverage          59.46%   59.46%           
==============================================
  Files               2830     2830           
  Lines              68627    68627           
  Branches           15181    15181           
==============================================
  Hits               40808    40808           
  Misses             25149    25149           
  Partials            2670     2670           
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Feb 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 27, 2025
@kodiakhq kodiakhq bot merged commit d18876a into release-7.4.0 Feb 27, 2025
50 of 51 checks passed
@kodiakhq kodiakhq bot deleted the regression/regex-error-multi-line-code branch February 27, 2025 12:55
@ggazzo
Copy link
Member

ggazzo commented Feb 27, 2025

@abhinavkrin @MarcosSpessatto How do we make sure this doesn't happen again tomorrow when someone updates the minor dependencies?

any test that could prevent that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants