-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: 2FA check flashing for mandatory roles #35340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d06ded3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35340 +/- ##
========================================
Coverage 59.67% 59.67%
========================================
Files 2826 2826
Lines 68309 68309
Branches 15131 15131
========================================
Hits 40762 40762
Misses 24936 24936
Partials 2611 2611
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@kody start-review |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Dismissing while we discuss the use of getDefaultUserFields().
|
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
faa89ac
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request addresses an issue in the Rocket.Chat repository related to the flashing of the two-factor authentication (2FA) check for mandatory roles. The changes are made in the
fix/2FA-mandatory-check-flashingbranch and are intended to be merged into thedevelopbranch.The modifications include:
apps/meteor/app/authentication/server/startup/index.js: The user fields projection is updated by replacing
getBaseUserFieldswithgetBaseUserFieldsWithTwoFactor. This change ensures that two-factor authentication fields are included in the default published fields for user accounts.apps/meteor/app/utils/server/functions/getBaseUserFields.ts: A new function,
getBaseUserFieldsWithTwoFactor, is added. This function returns user fields that include 2FA settings, enhancing the handling of user data with respect to two-factor authentication.apps/meteor/server/startup/initialData.js: The code now includes logic to insert an admin user using environment variables. It also manages different scenarios such as the presence of existing admins, identifying the oldest user, and operating in test mode.
These changes aim to improve the handling of two-factor authentication for users with mandatory roles, ensuring a more stable and secure authentication process.
CORE-1000