Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Feb 25, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-36

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 25, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: c4898b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.42%. Comparing base (5198fc4) to head (c4898b3).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35333   +/-   ##
========================================
  Coverage    59.42%   59.42%           
========================================
  Files         2829     2829           
  Lines        68332    68334    +2     
  Branches     15133    15133           
========================================
+ Hits         40608    40610    +2     
  Misses       25066    25066           
  Partials      2658     2658           
Flag Coverage Δ
unit 75.50% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review February 26, 2025 14:44
@KevLehman KevLehman requested review from a team as code owners February 26, 2025 14:44
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on apps side

@sampaiodiego
Copy link
Member

@kody start-review

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Feb 27, 2025
@KevLehman KevLehman added this to the 7.5.0 milestone Feb 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 27, 2025
@kodiakhq kodiakhq bot merged commit 4a123e3 into develop Feb 27, 2025
49 of 50 checks passed
@kodiakhq kodiakhq bot deleted the refactor/livechat-breakdown-2 branch February 27, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants