-
Notifications
You must be signed in to change notification settings - Fork 13k
refactor: Break down LivechatTyped into smaller components
#35333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35333 +/- ##
========================================
Coverage 59.42% 59.42%
========================================
Files 2829 2829
Lines 68332 68334 +2
Branches 15133 15133
========================================
+ Hits 40608 40610 +2
Misses 25066 25066
Partials 2658 2658
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on apps side
|
@kody start-review |
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-36
Steps to test or reproduce
Further comments