Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Feb 25, 2025

When Preview Public Channel authorization is not in the user permissions group and an app is preventing the same user to join, the UI should dispatch a toast error message with the app reason.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SUP-742

CORE-957

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 25, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: 1c2a35f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp changed the title fix fix: Apps preventing join actions not showing any error Feb 25, 2025
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.67%. Comparing base (0d96d63) to head (1c2a35f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35332   +/-   ##
========================================
  Coverage    59.67%   59.67%           
========================================
  Files         2826     2826           
  Lines        68313    68313           
  Branches     15134    15134           
========================================
  Hits         40764    40764           
  Misses       24937    24937           
  Partials      2612     2612           
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tiagoevanp
Copy link
Contributor Author

Tests will be covered in another PR

@tiagoevanp tiagoevanp marked this pull request as ready for review March 2, 2025 19:54
@tiagoevanp tiagoevanp requested a review from a team as a code owner March 2, 2025 19:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35332/

Built to branch gh-pages at 2025-03-20 05:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@MarcosSpessatto MarcosSpessatto self-requested a review March 17, 2025 12:58
@MarcosSpessatto MarcosSpessatto added this to the 7.5.0 milestone Mar 17, 2025
@tiagoevanp tiagoevanp force-pushed the fix/app-preventing-error branch from 1cbe906 to 4a81fe1 Compare March 20, 2025 03:48
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Mar 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2025
@tiagoevanp tiagoevanp dismissed gabriellsh’s stale review March 20, 2025 07:10

in favor of Tasso's review

@kodiakhq kodiakhq bot merged commit c0c91ce into develop Mar 20, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the fix/app-preventing-error branch March 20, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants