Skip to content

Conversation

@ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Feb 25, 2025

Proposed changes (including videos or screenshots)

As per CORE-992, this PR ensures inquiries are correctly routed to the manager's queue when a contact manager is attached and manual routing is enabled.

Issue(s)

Steps to test or reproduce

  1. Set omnichannel routing to manual.
  2. Create two agents.
  3. Create a contact with a known name and email, and assign it to one of the agents.
  4. Create a livechat inquiry using the contact’s details.
  5. Verify that the inquiry is only assigned to the contact’s designated manager.

Test cases:

  • Route to the correct online contact manager when routing is set to Manual Selection.
  • Route to the correct contact manager when routing is set to Manual Selection, contact manager is offline, and Livechat_accept_chats_with_no_agents is true.
  • Route to general queue when the contact manager is offline, and Livechat_accept_chats_with_no_agents is false.

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 25, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: 6ffd482

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/ddp-client Patch
@rocket.chat/meteor Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (041198c) to head (6ffd482).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35328      +/-   ##
===========================================
- Coverage    59.67%   59.64%   -0.04%     
===========================================
  Files         2826     2827       +1     
  Lines        68357    68522     +165     
  Branches     15142    15195      +53     
===========================================
+ Hits         40793    40867      +74     
- Misses       24951    24999      +48     
- Partials      2613     2656      +43     
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim ricardogarim force-pushed the fix/livechat-manual-routing-queue branch from a368859 to 2370039 Compare February 26, 2025 14:02
@ricardogarim ricardogarim marked this pull request as ready for review February 26, 2025 15:33
@ricardogarim ricardogarim requested review from a team as code owners February 26, 2025 15:33
@ricardogarim ricardogarim added this to the 7.5.0 milestone Feb 26, 2025
@aleksandernsilva
Copy link
Contributor

@ricardogarim Don't forget to add a changeset ℹ️

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35328/

Built to branch gh-pages at 2025-03-19 21:53 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

ishaan-arora-1 added a commit to ishaan-arora-1/Rocket.Chat that referenced this pull request Mar 11, 2025
@ricardogarim ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025
@ricardogarim ricardogarim modified the milestone: 7.5.0 Mar 19, 2025
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025
@ricardogarim ricardogarim removed the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025
@ricardogarim ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025
@kodiakhq kodiakhq bot merged commit a0c5f39 into develop Mar 19, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/livechat-manual-routing-queue branch March 19, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants