Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Feb 24, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-36

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 24, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 59.42%. Comparing base (424f613) to head (136bc90).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35324      +/-   ##
===========================================
- Coverage    59.44%   59.42%   -0.02%     
===========================================
  Files         2829     2829              
  Lines        68324    68336      +12     
  Branches     15130    15133       +3     
===========================================
  Hits         40612    40612              
- Misses       25054    25066      +12     
  Partials      2658     2658              
Flag Coverage Δ
unit 75.50% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review February 24, 2025 20:00
@KevLehman KevLehman requested review from a team as code owners February 24, 2025 20:01
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Feb 25, 2025
@KevLehman KevLehman added this to the 7.5.0 milestone Feb 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: 136bc90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit a2460ef into develop Feb 25, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the refactor/livechat-breakdown branch February 25, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants