feat: Require token name when creating personal access token #35315
+58
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 311f264 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
xmaxlad
changed the title
dougfabris
requested changes
Feb 26, 2025
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
@xmaxlad Hey, thanks for the contribution!
Instead of dispatching a toast, can we add a FieldError to the Field?
For your reference
dougfabris
changed the title
dougfabris
previously approved these changes
May 29, 2025
dougfabris
force-pushed
the
improve/only-allow-creating-token-with-name
branch
from
3de1f21 to
f60bcb3
Compare
gabriellsh
changed the title
FragaKrummenauer
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
approved these changes
Jun 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35315 +/- ##
===========================================
- Coverage 64.35% 62.75% -1.60%
===========================================
Files 3139 3024 -115
Lines 104662 102697 -1965
Branches 19759 19324 -435
===========================================
- Hits 67350 64447 -2903
- Misses 34628 35804 +1176
+ Partials 2684 2446 -238
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jeanfbrito
pushed a commit
that referenced
this pull request
Jun 18, 2025
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
This was referenced Jun 20, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Only allow creating PAT with a name.
If user clicks on 'Add' without giving a name, an error message is displayed, requiring the PAT name.
If users enters a name, the PAT is created as before with no changes.
Issue(s)
closes: #35314
Currently users can create a PAT without a name (an empty string). Which is not a appropriate case, creating tokens with no name can lead to confusion if there are multiple such tokens.
Steps to test or reproduce
Further comments
The pull request displays a error message that informs the user to provide a name to the token rather than creating a PAT without no name.
Looking forward to any views or comments.
CORE-1085