Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Feb 21, 2025

Remove meteor functions from the OAuth watcher function

Demo gif:
remove_meteor_OAuth

Jira task: ARCH-1477

Steps to test

  1. Access the useCustomOAuth.ts hook;
  2. Add some console.logs;
  3. Go to Administration > Workspace > Settings > OAuth > Custom OAuth and add a new custom OAuth;
  4. Have a look at your dev tools console;

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: c06f2c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (40ab1c4) to head (c06f2c9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35303   +/-   ##
========================================
  Coverage    59.64%   59.64%           
========================================
  Files         2828     2828           
  Lines        68533    68533           
  Branches     15192    15192           
========================================
  Hits         40879    40879           
  Misses       25006    25006           
  Partials      2648     2648           
Flag Coverage Δ
unit 75.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35303/

Built to branch gh-pages at 2025-03-12 14:07 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@rique223 rique223 marked this pull request as ready for review March 10, 2025 22:06
@rique223 rique223 requested a review from a team as a code owner March 10, 2025 22:06
@rique223 rique223 added this to the 7.5.0 milestone Mar 11, 2025
rique223
rique223 previously approved these changes Mar 11, 2025
@rique223 rique223 added the stat: QA assured Means it has been tested and approved by a company insider label Mar 12, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 12, 2025
@ggazzo ggazzo merged commit 5294fed into develop Mar 12, 2025
9 of 10 checks passed
@ggazzo ggazzo deleted the chore/remove-meteor-customOauth branch March 12, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants