Skip to content

Conversation

@juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

The email verification on admin/users wasn't working due to a condition added on saveUser that was preventing verified to be updated.

Issue(s)

Steps to test or reproduce

  • go to admin/users
  • select a user and click Edit
  • check Mark email as verified
  • save

User should have the email verified.

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: b8dcbce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (5cc6b21) to head (b8dcbce).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35299   +/-   ##
========================================
  Coverage    59.72%   59.72%           
========================================
  Files         2830     2830           
  Lines        68363    68363           
  Branches     15161    15161           
========================================
  Hits         40829    40829           
  Misses       24918    24918           
  Partials      2616     2616           
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review February 26, 2025 19:55
@juliajforesti juliajforesti requested a review from a team February 26, 2025 19:55
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test would be awesome 😬

@juliajforesti juliajforesti marked this pull request as draft February 28, 2025 20:13
@juliajforesti juliajforesti force-pushed the fix/email-verified branch 3 times, most recently from 77a0d97 to bff76cd Compare March 5, 2025 16:10
@juliajforesti juliajforesti marked this pull request as ready for review March 5, 2025 17:14
@juliajforesti juliajforesti added this to the 7.5.0 milestone Mar 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35299/

Built to branch gh-pages at 2025-03-21 21:14 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025
@scuciatto scuciatto modified the milestones: 7.5.0, 7.6.0 Mar 24, 2025
@kodiakhq kodiakhq bot merged commit a6d95d7 into develop Mar 24, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/email-verified branch March 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants