Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 21, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-997

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: fbe336c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (bac1a0c) to head (fbe336c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35298      +/-   ##
===========================================
- Coverage    59.44%   59.44%   -0.01%     
===========================================
  Files         2829     2829              
  Lines        68326    68324       -2     
  Branches     15131    15130       -1     
===========================================
- Hits         40614    40612       -2     
  Misses       25054    25054              
  Partials      2658     2658              
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the fix/backupCodes-regenerate branch from 1d6c34a to 96d4c1f Compare February 21, 2025 15:23
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice, please test bro <3

@dougfabris dougfabris force-pushed the fix/backupCodes-regenerate branch from 96d4c1f to 681bc01 Compare February 21, 2025 19:54
@dougfabris dougfabris marked this pull request as ready for review February 24, 2025 12:45
@dougfabris dougfabris requested a review from a team as a code owner February 24, 2025 12:45
@dougfabris dougfabris added this to the 7.5.0 milestone Feb 24, 2025
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changeset?

@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Feb 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 24, 2025
@kodiakhq kodiakhq bot merged commit 5457e94 into develop Feb 25, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/backupCodes-regenerate branch February 25, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants