Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Feb 21, 2025

Proposed changes (including videos or screenshots)

The problem is: since we store the current query on the local storage, old installations will have some data that's no longer compatible with the new version. For example, fields that have been converted to be an array instead of an string will fail to be processed.
The work to support both, or to make the old compatible with the new is greater than what we get from them (after the first use, the code to support old stored value would become legacy as a new payload will be stored, rendering the code useless from that point). So, quickest solution: change the key where we store, allowing new installations to set new data, and old installations to not fail :)

Issue(s)

Steps to test or reproduce

Further comments

Introduced here: #35147

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: fff4149

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.4.0@91af64b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.4.0   #35297   +/-   ##
================================================
  Coverage                 ?   59.44%           
================================================
  Files                    ?     2829           
  Lines                    ?    68324           
  Branches                 ?    15131           
================================================
  Hits                     ?    40612           
  Misses                   ?    25054           
  Partials                 ?     2658           
Flag Coverage Δ
unit 75.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 7.4.0 milestone Feb 21, 2025
@KevLehman KevLehman marked this pull request as ready for review February 21, 2025 16:47
@KevLehman KevLehman requested a review from a team as a code owner February 21, 2025 16:47
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Feb 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 21, 2025
@kodiakhq kodiakhq bot merged commit 236d247 into release-7.4.0 Feb 21, 2025
51 of 52 checks passed
@kodiakhq kodiakhq bot deleted the regression/old-query branch February 21, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants