Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Feb 21, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-995

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 3360d16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego marked this pull request as ready for review February 21, 2025 13:15
@sampaiodiego sampaiodiego requested a review from a team as a code owner February 21, 2025 13:15
@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (683df29) to head (3360d16).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35295   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2829     2829           
  Lines        68324    68324           
  Branches     15130    15130           
========================================
  Hits         40612    40612           
  Misses       25054    25054           
  Partials      2658     2658           
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Feb 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 25, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 25, 2025
@sampaiodiego sampaiodiego added the stat: ready to merge PR tested and approved waiting for merge label Feb 25, 2025
@kodiakhq kodiakhq bot merged commit 424f613 into develop Feb 25, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the chore-remove-subscription-type-casting branch February 25, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants