Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 20, 2025

Proposed changes (including videos or screenshots)

Adds CodeSnippet to keep ui consistency and also replace Modal in favor of GenericModal

before

after

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 20, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: a63cdfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.5.0 milestone Feb 20, 2025
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (8981bd8) to head (a63cdfd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35287      +/-   ##
===========================================
- Coverage    59.44%   59.44%   -0.01%     
===========================================
  Files         2829     2829              
  Lines        68326    68325       -1     
  Branches     15131    15131              
===========================================
- Hits         40614    40613       -1     
  Misses       25054    25054              
  Partials      2658     2658              
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review February 20, 2025 22:43
@dougfabris dougfabris requested a review from a team as a code owner February 20, 2025 22:43
Copy link
Contributor

@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Feb 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 21, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 21, 2025
@juliajforesti juliajforesti added the stat: ready to merge PR tested and approved waiting for merge label Feb 21, 2025
@kodiakhq kodiakhq bot merged commit 79aa3c7 into develop Feb 21, 2025
49 of 50 checks passed
@kodiakhq kodiakhq bot deleted the refactor/backupCodes-modal branch February 21, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants