-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: UI validation for existing email during user registration #35277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: UI validation for existing email during user registration #35277
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: dc912dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I just realized that 'tasked' issues are already assigned. |
MartinSchoeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that 'tasked' issues are already assigned. As tasked issues have been referred to the devs for them to fix. Should I close this PR, or would it still be helpful in any way? I'll make sure to pick unassigned issues next time.
I don't think anyone is working on that at the moment, so it should be fine
Can you fix the lint errors?
Thanks!
I have fixed the lint errors . |
4274758
148384f to
4274758
Compare




Proposed changes (including videos or screenshots)
Screencast.from.2025-02-20.22-40-53.webm
Issue(s)
Closes #35263
CORE-1011
Steps to test or reproduce
Further comments
This pull request addresses an issue in the Rocket.Chat user registration process by implementing a fix for email validation to prevent duplicate email registrations. The changes include:
UI Validation: A changeset has been introduced to enhance the registration form's email validation, ensuring that users cannot register with an email that is already in use.
API Enhancement: The user registration API endpoint (
users.register) has been updated to include an email availability check. ThecheckEmailAvailabilityfunction is now used to verify if the provided email already exists in the system. If the email is found to be already registered, an error is returned, preventing the creation of a new user with the same email.These changes are made in the source branch
fix/email-already-registeredand are intended to be merged into thedevelopbranch.