fix: Switching from DM to channel throws an error

[gabriellsh]

Proposed changes (including videos or screenshots)

There are 2 things that in conjunction cause this issue:

1. RoomRoute component was keeping it's state when transitioning through different rooms. This causes the room's type and reference (id or name) property to be incorrectly extracted from the URL, and reference becomes null.

2. getRoomByTypeAndName method returns the first DM subscription ever created if you send the parameters type as 'd' and name as null. It only results in that DM if you have access to it (e.g you created or is part of it), so it's not a security issue, but shouldn't happen.

Issue(s)

CORE-1060

Steps to test or reproduce

1. Create a new server and register your admin account.
2. Create a new user, and a DM with said user.
3. On the browser devtools, go to performance tab and set CPU throttling to 6x (this depends on your PC's hardware, so you might need more or less throttling).
4. Open the web application, navigate to a room, than to the new DM, then try to go back.
5. An error should be shown.

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 1bc2e3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (8e99a2e) to head (1bc2e3d).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #35269   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2829     2829           
  Lines        68326    68326           
  Branches     15131    15131           
========================================
  Hits         40614    40614           
  Misses       25054    25054           
  Partials      2658     2658           

Flag	Coverage Δ
unit	75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[julio-rocketchat]

/backport 7.3.6

[dionisio-bot]

Pull request #36266 added to Project: "Patch 7.3.6"