feat: improve IM/DM messages sorting to support multiple parameters #35260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhinav Kumar <[email protected]>
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7e4fc28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35260 +/- ##
========================================
Coverage 59.44% 59.44%
========================================
Files 2828 2828
Lines 68166 68166
Branches 15124 15124
========================================
Hits 40521 40521
Misses 24989 24989
Partials 2656 2656
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
abhinavkrin
commented
Feb 19, 2025
abhinavkrin
commented
Feb 19, 2025
MarcosSpessatto
approved these changes
Feb 19, 2025
abhinavkrin
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
scuciatto
removed
the
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
scuciatto
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR improves the sorting behavior of IM/DM messages by allowing multiple sorting parameters instead of relying solely on the
tstimestamp. This brings consistency with group/channel messages and allows for better customization.Issue(s)
Closes #34008
Steps to test or reproduce
Further comments
CORE-830