Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Feb 18, 2025

Proposed changes (including videos or screenshots)

This endpoint enables the querying of the server_events collection for settings.changed audit events.

Issue(s)

LOG-11

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: eccabd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (38f1c50) to head (eccabd7).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35258   +/-   ##
========================================
  Coverage    59.66%   59.66%           
========================================
  Files         2826     2826           
  Lines        68369    68369           
  Branches     15148    15148           
========================================
  Hits         40793    40793           
  Misses       24962    24962           
  Partials      2614     2614           
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Feb 24, 2025
@scuciatto scuciatto added this to the 7.5.0 milestone Feb 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35258/

Built to branch gh-pages at 2025-03-18 17:45 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review March 13, 2025 19:32
@MartinSchoeler MartinSchoeler requested review from a team as code owners March 13, 2025 19:32
MartinSchoeler
MartinSchoeler previously approved these changes Mar 13, 2025
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 14, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 14, 2025
@ggazzo
Copy link
Member

ggazzo commented Mar 14, 2025

what do you think about convert to the new way, to generate api docs already?

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Mar 18, 2025
@gabriellsh gabriellsh marked this pull request as ready for review March 18, 2025 17:17
@gabriellsh gabriellsh added this to the 7.5.0 milestone Mar 18, 2025
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Mar 18, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 18, 2025
@kodiakhq kodiakhq bot merged commit bb4ff0d into develop Mar 18, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the new/auditSettingsEndpoint branch March 18, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants