Skip to content

fix: ddp-streamer restart keeping opened connections #35243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 1 commit into from
Feb 20, 2025
Merged

fix: ddp-streamer restart keeping opened connections #35243

sampaiodiego merged 1 commit into from
Feb 20, 2025

Conversation

@dionisio-bot
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Feb 17, 2025

Backport of #35195

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner February 17, 2025 22:15
@dionisio-bot dionisio-bot bot requested a review from sampaiodiego February 17, 2025 22:15
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e600f70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 7.0 milestone Feb 17, 2025
@dionisio-bot
Copy link
Contributor Author

dionisio-bot bot commented Feb 17, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added backport and removed backport labels Feb 17, 2025
@dionisio-bot dionisio-bot bot mentioned this pull request Feb 17, 2025
Merged
@codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.68%. Comparing base (270c69c) to head (e600f70).
Report is 1 commits behind head on release-7.0.7.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.7   #35243   +/-   ##
==============================================
  Coverage          58.68%   58.68%           
==============================================
  Files               2789     2789           
  Lines              66846    66846           
  Branches           15026    15026           
==============================================
  Hits               39229    39229           
  Misses             24795    24795           
  Partials            2822     2822
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35243/

Built to branch gh-pages at 2025-02-17 22:31 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@sampaiodiego sampaiodiego merged commit ac71181 into release-7.0.7 Feb 20, 2025
55 of 56 checks passed
@sampaiodiego sampaiodiego deleted the backport-7.0.7-35195 branch February 20, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

@sampaiodiego sampaiodiego

Labels

None yet

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

1 participant

@sampaiodiego