Skip to content

Conversation

@julio-rocketchat
Copy link
Member

@julio-rocketchat julio-rocketchat commented Feb 17, 2025

This PR has already received approvals here: 760

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: 8cd8b98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (aadbcbc) to head (f3a46b7).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35231   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2827     2827           
  Lines        68163    68163           
  Branches     15123    15123           
========================================
  Hits         40517    40517           
  Misses       24990    24990           
  Partials      2656     2656           
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-rocketchat julio-rocketchat force-pushed the imported-fixes-2025-02-17 branch from 91fd740 to 8cd8b98 Compare February 17, 2025 10:46
@julio-rocketchat julio-rocketchat added this to the 7.4.0 milestone Feb 17, 2025
@julio-rocketchat julio-rocketchat marked this pull request as ready for review February 17, 2025 11:35
@julio-rocketchat julio-rocketchat requested a review from a team as a code owner February 17, 2025 11:35
Signed-off-by: Abhinav Kumar <[email protected]>
@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Feb 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 17, 2025
@kodiakhq kodiakhq bot merged commit b9e7e38 into develop Feb 17, 2025
49 of 50 checks passed
@kodiakhq kodiakhq bot deleted the imported-fixes-2025-02-17 branch February 17, 2025 13:18
@julio-rocketchat
Copy link
Member Author

/backport 7.3.2

dionisio-bot bot pushed a commit that referenced this pull request Feb 17, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Pull request #35234 added to Project: "Patch 7.3.2"

@abhinavkrin
Copy link
Member

/backport 7.2.3

dionisio-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Pull request #35246 added to Project: "Patch 7.2.3"

@abhinavkrin
Copy link
Member

/backport 7.1.3

dionisio-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Pull request #35247 added to Project: "Patch 7.1.3"

@abhinavkrin
Copy link
Member

/backport 7.0.7

dionisio-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Pull request #35248 added to Project: "Patch 7.0.7"

@abhinavkrin
Copy link
Member

/backport 6.13.2

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-6.13.2-35231
git cherry-pick b9e7e38e16cd5edf9a41a4bfd23942ce07a8eb16
// solve the conflict
git push

after that just run /backport 6.13.2 again

abhinavkrin added a commit that referenced this pull request Feb 18, 2025
@abhinavkrin
Copy link
Member

/backport 6.13.2

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Pull request #35250 added to Project: "Patch 6.13.2"

abhinavkrin added a commit that referenced this pull request Feb 18, 2025
@abhinavkrin
Copy link
Member

/backport 6.13.2

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Pull request #35252 added to Project: "Patch 6.13.2"

sampaiodiego pushed a commit that referenced this pull request Feb 18, 2025
sampaiodiego pushed a commit that referenced this pull request Feb 18, 2025
abhinavkrin added a commit that referenced this pull request Feb 18, 2025
abhinavkrin added a commit that referenced this pull request Feb 18, 2025
@julio-rocketchat
Copy link
Member Author

/backport 6.13.2

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 3, 2025

Pull request #35693 added to Project: "Patch 6.13.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants