feat: display leader role group in rooms' members list #35208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f7bf5eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35208 +/- ##
===========================================
+ Coverage 59.44% 59.46% +0.01%
===========================================
Files 2828 2829 +1
Lines 68154 68279 +125
Branches 15124 15118 -6
===========================================
+ Hits 40516 40601 +85
- Misses 24982 25025 +43
+ Partials 2656 2653 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
MarcosSpessatto
suggested changes
Feb 17, 2025
Signed-off-by: Abhinav Kumar <[email protected]>
MarcosSpessatto
previously approved these changes
Feb 17, 2025
aleksandernsilva
previously approved these changes
Feb 17, 2025
…-room chore: remove leader bar from chat room header
abhinavkrin
dismissed stale reviews from aleksandernsilva and MarcosSpessatto
via
38252de
Member
Author
|
Merged #35209 which removes the LeaderBar from the chat room header. |
MarcosSpessatto
approved these changes
Feb 19, 2025
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MartinSchoeler
approved these changes
Feb 19, 2025
MartinSchoeler
added
stat: ready to merge
Merged
This was referenced Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR adds the Leader role to the members list (contextual bar) to ensure better visibility and role consistency. Previously, the Leader role was displayed only in the room header, which created inconsistencies in role presentation.
Issue(s)
Steps to test or reproduce
Further comments
CORE-975