fix: adds contact manager check before assigning to agent #35205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c2c8f6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ricardogarim
changed the title
ricardogarim
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35205 +/- ##
===========================================
- Coverage 59.67% 59.64% -0.04%
===========================================
Files 2829 2828 -1
Lines 68786 68537 -249
Branches 15236 15191 -45
===========================================
- Hits 41051 40879 -172
+ Misses 25076 25010 -66
+ Partials 2659 2648 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
MarcosSpessatto
suggested changes
Feb 17, 2025
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we add some tests to ensure this behavior?
apps/meteor/ee/app/livechat-enterprise/server/hooks/handleNextAgentPreferredEvents.ts
Show resolved
Hide resolved
aleksandernsilva
requested changes
Feb 17, 2025
KevLehman
requested changes
Feb 17, 2025
ricardogarim
force-pushed
the
fix/livechat-routing-contact-manager
branch
from
4a94986 to
bb6acd7
Compare
ricardogarim
requested review from
KevLehman,
MarcosSpessatto and
aleksandernsilva
MarcosSpessatto
suggested changes
Feb 18, 2025
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
MarcosSpessatto
approved these changes
Feb 18, 2025
aleksandernsilva
approved these changes
Feb 19, 2025
Contributor
aleksandernsilva
left a comment
aleksandernsilva
left a comment
There was a problem hiding this comment.
LGTM
PS.: If you could create a separate PR with tests covering this scenario would be much appreciated.
KevLehman
approved these changes
Feb 19, 2025
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
Contributor
|
scuciatto
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes the Livechat routing algorithm to correctly assign conversations to the contact manager when triggers and/or automatic agent routing are enabled.
Checking contact manager on callback
livechat.checkDefaultAgentOnNewRoom: we now verify if the user has a different contact manager than the one initially assigned viaagent.nextorlivechat.configroutes.Handling contact manager on guest registration: in the
registerGuestmethod (server lib), we now check if the provided email is already associated with a contact manager. If a contact manager is found, the response from the visitor creation endpoint will include the correct manager data. This ensures that the Livechat widget UI correctly reflects agent changes during visitor creation.Issue(s)
Steps to test or reproduce
Further comments