Skip to content

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Feb 13, 2025

Proposed changes (including videos or screenshots)

Enhances the server-setting.read permission, allowing it to take an array of hiddenPermissions, that are the permissions that can be searched despite being hidden (or secret). This enables us to have a Omnigateway_Url setting.

This setting is going to be responsible to have the omnigateway of the current env. By having this setting, we can easily stage our omni-apps, because, instead of having the value of the omnigateway url hardcoded, it will be just a matter of fetching the value of the setting through the apps-engine. Thus, centralizing the information

Issue(s)

Steps to test or reproduce

Further comments

CONN-525

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 13, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: a7272fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/apps-engine Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/rest-typings Minor
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Gustrb Gustrb added this to the 7.4.0 milestone Feb 13, 2025
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.45%. Comparing base (dc8e8b9) to head (a7272fb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35199   +/-   ##
========================================
  Coverage    59.45%   59.45%           
========================================
  Files         2828     2828           
  Lines        68159    68159           
  Branches     15124    15124           
========================================
  Hits         40521    40521           
  Misses       24982    24982           
  Partials      2656     2656           
Flag Coverage Δ
unit 75.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb changed the title chore: adds a new omnigateway setting feat: enable configuring which hidden settings are available for the apps Feb 13, 2025
@Gustrb Gustrb marked this pull request as ready for review February 14, 2025 09:01
@Gustrb Gustrb requested review from a team as code owners February 14, 2025 09:01
@d-gubert d-gubert changed the title feat: enable configuring which hidden settings are available for the apps feat(apps): enable configuring which hidden settings are available for the apps Feb 14, 2025
@Gustrb Gustrb requested review from KevLehman and d-gubert February 14, 2025 17:54
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Feb 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 19, 2025
@kodiakhq kodiakhq bot merged commit 697a38d into develop Feb 19, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-omnigateway-setting branch February 19, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants