-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Users without preview permission possibility of subscribe to public channel stream #35194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: db49ae2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35194 +/- ##
========================================
Coverage 59.44% 59.44%
========================================
Files 2829 2829
Lines 68332 68326 -6
Branches 15132 15131 -1
========================================
- Hits 40617 40614 -3
+ Misses 25057 25054 -3
Partials 2658 2658
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/server/modules/notifications/notifications.module.ts
Outdated
Show resolved
Hide resolved
…t.Chat into fix/stream-room-message
f5d986b to
bd329b2
Compare
apps/meteor/server/modules/notifications/notifications.module.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre Lehnen <[email protected]>
287f4b7 to
90e0da8
Compare
Proposed changes (including videos or screenshots)
Remove the possibility of listening to
room-messagesstream of public channels without being subscribed into it.related to #34922
Issue(s)
Steps to test or reproduce
Further comments
CORE-950