Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Feb 12, 2025

Proposed changes (including videos or screenshots)

Remove the possibility of listening to room-messages stream of public channels without being subscribed into it.

related to #34922

Issue(s)

Steps to test or reproduce

Further comments

CORE-950

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 12, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: db49ae2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (43cc75b) to head (7be5eb7).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35194   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2829     2829           
  Lines        68332    68326    -6     
  Branches     15132    15131    -1     
========================================
- Hits         40617    40614    -3     
+ Misses       25057    25054    -3     
  Partials      2658     2658           
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp added this to the 7.4.0 milestone Feb 13, 2025
@tiagoevanp tiagoevanp marked this pull request as ready for review February 13, 2025 17:45
@tiagoevanp tiagoevanp requested a review from a team as a code owner February 13, 2025 17:45
@tiagoevanp tiagoevanp force-pushed the fix/stream-room-message branch from f5d986b to bd329b2 Compare February 13, 2025 19:05
@tiagoevanp tiagoevanp force-pushed the fix/stream-room-message branch from 287f4b7 to 90e0da8 Compare February 14, 2025 18:50
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Feb 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 20, 2025
@kodiakhq kodiakhq bot merged commit 8e99a2e into develop Feb 20, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/stream-room-message branch February 20, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants