-
Notifications
You must be signed in to change notification settings - Fork 13.1k
fix: empty "Apps_Error_" toast message when private app installation fails #35189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0a38958 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35189 +/- ##
========================================
Coverage 59.31% 59.31%
========================================
Files 2825 2825
Lines 68158 68158
Branches 15123 15123
========================================
Hits 40430 40430
Misses 24900 24900
Partials 2828 2828
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Issue(s)
CORE-985
Steps to test or reproduce
Empty error would show up if RC failed to store the app file to disk or if it failed to create an user for the app.
Should be reproduceable by configuring an invalid storage for the apps
Further comments