Skip to content

regression: fix urlencoded hooks #35183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Feb 18, 2025
Merged

regression: fix urlencoded hooks #35183

kodiakhq merged 3 commits into from
Feb 18, 2025

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Feb 11, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Introduced by #34999

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 11, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (da4a919) to head (2ae81d2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35183   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2828     2828           
  Lines        68168    68168           
  Branches     15124    15124           
========================================
  Hits         40522    40522           
  Misses       24990    24990           
  Partials      2656     2656
Flag Coverage Δ
unit 75.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ae81d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego force-pushed the regression-urlencoded-hooks branch 2 times, most recently from fc00115 to f47b2b8 Compare February 13, 2025 13:57
@sampaiodiego sampaiodiego marked this pull request as ready for review February 13, 2025 13:57
@sampaiodiego sampaiodiego force-pushed the regression-urlencoded-hooks branch from f47b2b8 to 3b55dbb Compare February 13, 2025 20:40
@sampaiodiego sampaiodiego requested a review from a team February 14, 2025 14:09
@sampaiodiego sampaiodiego added this to the 7.4.0 milestone Feb 14, 2025
MarcosSpessatto
MarcosSpessatto suggested changes Feb 14, 2025
View reviewed changes
MarcosSpessatto
MarcosSpessatto approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the PR that introduced the regression please?

@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Feb 18, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35183/

Built to branch gh-pages at 2025-02-18 21:45 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@kodiakhq kodiakhq bot merged commit efb4503 into develop Feb 18, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the regression-urlencoded-hooks branch February 18, 2025 22:18
@felixfontein felixfontein mentioned this pull request Mar 17, 2025
Closed
@sampaiodiego sampaiodiego mentioned this pull request Mar 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sampaiodiego @MarcosSpessatto