Skip to content

Conversation

@julio-rocketchat
Copy link
Member

@julio-rocketchat julio-rocketchat commented Feb 11, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/ARCH-1454
https://rocketchat.atlassian.net/browse/VLN-100

Steps to test or reproduce

Further comments

@julio-rocketchat julio-rocketchat requested a review from a team as a code owner February 11, 2025 18:04
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 11, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: bd326bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/authorization-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/account-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/queue-worker Patch
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@julio-rocketchat julio-rocketchat added this to the 7.4.0 milestone Feb 11, 2025
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (ed3f483) to head (bd326bd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35181      +/-   ##
===========================================
- Coverage    59.44%   59.44%   -0.01%     
===========================================
  Files         2827     2827              
  Lines        68163    68162       -1     
  Branches     15123    15123              
===========================================
- Hits         40517    40516       -1     
  Misses       24990    24990              
  Partials      2656     2656              
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman
Copy link
Member

I see there's a new meteor version, can you check if that comes with this new node version too? THen would be better to update it completely

@julio-rocketchat julio-rocketchat changed the title chore(deps): bump node version from 22.11.0 to 22.13.1 chore(deps): bump node version from 22.11.0 to 22.13.1 and meteor to 3.1.2 Feb 12, 2025
Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets pray for the best 🙏🏽

@julio-rocketchat
Copy link
Member Author

Lets pray for the best 🙏🏽

Amen

@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Feb 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 17, 2025
@kodiakhq kodiakhq bot merged commit 9f6a7b4 into develop Feb 17, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the bump-node-version branch February 17, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants